support string classpath splitting #1559
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@testforstephen @jdneo this should be a quick and easy one, and then I don't have to have my own version installed / need to share it manually with the team 😆🥲 Edit, actually, now that I think about it... I think the delimiter needs to be something other than a colon :( I forgot about windows machines / |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright this might be a little niche, but I do think it'll come in handy for more than just me :)
The classpath resolver is being finnicky, and including jars that it shouldn't be (for the test scope, it seems). I'm not too worried about it, I know the configuration for this project is a bit "non-typical". So what I am doing is using launch.json -> configurations -> ( java ) -> classPaths to "exclude" them. Great, it works!
However, instead of manually adding each of them in, i'm running an
inputlike so"!${input:exclude-test-fixtures}",. This'll automagically go and get the jar paths that need skipping, separated by a colon (the proper delimiter). Ex:!/app/jar-1.jar:!/app/jar-2.jar:!/app/jar-2.jarThen with this change, all of those can be skipped proper.
I don't think this'll introduce any issues, since a path that would've been there could never include a colon already.